New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install face_recognition on Docker build #17502

Merged
merged 2 commits into from Oct 25, 2018

Conversation

Projects
None yet
4 participants
@lights0123
Contributor

lights0123 commented Oct 15, 2018

Description:

Install face_recognition in the Docker build. This is because image_processing.dlib_face_detect and image_processing.dlib_face_identify build dlib when installed, which requires cmake. This PR builds dlib before cmake is removed.

Related issue (if applicable): #17451, possibly #11605

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@lights0123 lights0123 requested a review from home-assistant/docker as a code owner Oct 15, 2018

@wafflebot wafflebot bot added the in progress label Oct 15, 2018

@@ -62,6 +63,10 @@ if [ "$INSTALL_SSOCR" == "yes" ]; then
virtualization/Docker/scripts/ssocr
fi
if [ "$INSTALL_DLIB" == "yes" ]; then
pip3 install --no-cache-dir face_recognition==1.0.0

This comment has been minimized.

@michaelarnauts

michaelarnauts Oct 17, 2018

Contributor

Just wondering, is there a way to just install dlib? I assume that is a dependency of face_recognition?

This comment has been minimized.

@lights0123

lights0123 Oct 17, 2018

Contributor

Yeah, the dlib PyPi package automatically builds it, which is a dependency of face_recognition. I could just only install dlib, but face_recognition isn’t a very big package to make a difference.

This comment has been minimized.

@michaelarnauts

michaelarnauts Oct 18, 2018

Contributor

The I prefer to just install dlib. The requirements will take sure of installing dlib.

Especially since it can get confusing when face_recognition gets updated and this script install an older version.

@michaelarnauts michaelarnauts merged commit 901c4f1 into home-assistant:dev Oct 25, 2018

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 93.6%
Details

@wafflebot wafflebot bot removed the in progress label Oct 25, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment