New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis - prepare for config entry #17566

Merged
merged 13 commits into from Oct 29, 2018

Conversation

@Kane610
Contributor

Kane610 commented Oct 17, 2018

Description:

Clean up Axis integration and prepare for config entry

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

Kane610 added some commits Jun 12, 2018

Simplify sensors by not having it split in two, improve naming of var…
…iables

Remove functionality to update ip address on new discovery

@Kane610 Kane610 force-pushed the Kane610:axis-simplify-component branch from 2c2a965 to 6835343 Oct 18, 2018

Kane610 added some commits Oct 22, 2018

Use hass.data instead of local dict for devices
Fix services.yaml
Add error handling
@Kane610

This comment has been minimized.

Contributor

Kane610 commented Oct 23, 2018

Great feedback @MartinHjelmare, thanks!

@Kane610 Kane610 changed the title from WIP: Axis - prepare for config entry to Axis - prepare for config entry Oct 23, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@MartinHjelmare

Looks good!

@Kane610

This comment has been minimized.

Contributor

Kane610 commented Oct 28, 2018

Thanks @MartinHjelmare will merge when Travis completes.

@Kane610 Kane610 merged commit 4579717 into home-assistant:dev Oct 29, 2018

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.6%) to 92.938%
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Oct 29, 2018

@Kane610 Kane610 deleted the Kane610:axis-simplify-component branch Oct 31, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment