New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hassio command timeout #17567

Merged
merged 2 commits into from Nov 3, 2018

Conversation

Projects
None yet
5 participants
@alex9446
Contributor

alex9446 commented Oct 18, 2018

Description:

With the slower devices, like my Raspberry Pi 1 Model B, 300 seconds (5 minutes) are not enough to check homeassistant configuration

core-ssh:~# time hassio ha check
ok

real	5m37.336s
user	0m0.048s
sys	0m0.016s

Related issue (if applicable): fixes #17177

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

hassio:
  check_timeout: 600

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob

This comment has been minimized.

Member

balloob commented Oct 18, 2018

User configuration option is the wrong solution to most problems. Because you're not solving anything, you're just outsourcing responsibility.

CC @pvizeli

@alex9446

This comment has been minimized.

Contributor

alex9446 commented Oct 18, 2018

You're right, especially because if don't configured the problem persists.

I thought about two possible ways to solve it:

  • By increase the time for all device and show a warning if call exceeds 5 minutes
  • Or increase timeout if the device is mark as slow

It could be the right solution?

@pvizeli

This comment has been minimized.

Member

pvizeli commented Nov 1, 2018

You can fix add a timeout of 600 for this command

@balloob balloob merged commit 782a90a into home-assistant:dev Nov 3, 2018

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.5%) to 93.061%
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Nov 3, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

@alex9446 alex9446 deleted the alex9446:fix-timeout branch Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment