New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MS face detection to handle updating entities when no face is detected #17593

Merged
merged 3 commits into from Nov 2, 2018

Conversation

Projects
None yet
4 participants
@NeilCrosby
Contributor

NeilCrosby commented Oct 18, 2018

Description:

This change allows for the MS Face Detection component (and the MS Face Identify component) to correctly report that the MS Face API has determined that there are no faces visible in the image that has been sent to it.

I have been using the change in the Face Detection component in my personal Home Assistant environment at home successfully for a couple of months now.

The additional tests failed before the changes in the two modules were made, and passed once that code had been added.

Related issue (if applicable): fixes #17590

Pull request in home-assistant.io with documentation (if applicable): No changes to the documentation required.

Example entry for configuration.yaml (if applicable):

n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
aioclient_mock.clear_requests()
aioclient_mock.post(
self.endpoint_url.format("detect"),
text=load_fixture('microsoft_face_detect_no_face_detected.json')

This comment has been minimized.

@pvizeli

pvizeli Nov 1, 2018

Member

please use text="[]" and remove this json file without a input

This comment has been minimized.

@NeilCrosby

NeilCrosby Nov 1, 2018

Contributor

👍

@pvizeli

pvizeli approved these changes Nov 2, 2018

@pvizeli pvizeli merged commit cb7ae5c into home-assistant:dev Nov 2, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 93.077%
Details

@wafflebot wafflebot bot removed the in progress label Nov 2, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment