Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add water_heater support to HomeKit #17614

Merged
merged 3 commits into from Oct 19, 2018

Conversation

Projects
None yet
3 participants
@cdce8p
Copy link
Member

commented Oct 19, 2018

Description:

This PR adds water_heater support for the HomeKit component. The implementation is mostly similar to the existing support for climate device. However setting the operation_mode through the Home App is not supported, due to technical constraints with HomeKit.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6958

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Documentation added/updated in home-assistant.io
  • Tests have been added to verify that the new code works.

cdce8p added some commits Oct 19, 2018

@cdce8p cdce8p referenced this pull request Oct 19, 2018

Merged

Add water_heater support HomeKit #6958

2 of 2 tasks complete

@cdce8p cdce8p force-pushed the cdce8p:homekit-water_heater branch from 087c25d to 1d83979 Oct 19, 2018

@cdce8p cdce8p merged commit ff33cbd into home-assistant:dev Oct 19, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.605%
Details

@wafflebot wafflebot bot removed the in progress label Oct 19, 2018

@cdce8p cdce8p deleted the cdce8p:homekit-water_heater branch Oct 19, 2018

@balloob balloob referenced this pull request Oct 26, 2018

Merged

0.81 #17809

@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.