New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch only required data from Huawei LTE #17618

Merged
merged 1 commit into from Dec 14, 2018

Conversation

@scop
Copy link
Contributor

scop commented Oct 19, 2018

Description:

Don't fetch data that is not going to be used. When debug logging is enabled, still fetch everything in order to provide indication of available/supported data to users, as instructed in docs.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
huawei_lte: Fetch only required data
When debug logging is enabled, still fetch everything in order to
provide indication of available/supported data to users, as instructed
in docs.
@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Nov 3, 2018

I'm not sure what will be in the right direction. That is more a general question and maybe we should write an architecture about this.

General, I would love to remove the CONF_MONITORED_CONDITIONS. Home Assistant should grab all available data and the user decide on UI what he want to see and in which way.

@scop

This comment has been minimized.

Copy link
Contributor

scop commented Nov 4, 2018

A problem is that it might not be possible to enumerate what "all available data" is, and offering only a subset would not be sustainably maintainable (or would be overly restrictive).

@fabaff fabaff changed the title huawei_lte: Fetch only required data Fetch only required data from Huawei LTE Dec 12, 2018

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 14, 2018

Pascal, I think that the current PR is not related to a discussion about monitored conditions. I would see this as an optimization.

@balloob balloob merged commit 1c147b5 into home-assistant:dev Dec 14, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 93.597%
Details

@wafflebot wafflebot bot removed the in progress label Dec 14, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 14, 2018

Merge branch 'dev' into current
* dev: (88 commits)
  huawei_lte: Fetch only required data (home-assistant#17618)
  Adding support for Plum Lightpad (home-assistant#16576)
  Fix restore state for manual alarm control panel (home-assistant#19284)
  Set InsteonEntity name to be combo of description and address. (home-assistant#17262)
  Device config for Fibaro hub integration (home-assistant#19171)
  Add air pollutants component (home-assistant#18707)
  Updated ELIQ Online sensor to async API (home-assistant#19248)
  Set unavailable when unreachable (home-assistant#19012)
  Make variable `entity_id` available to value_template for MQTT binary sensor (home-assistant#19195)
  home-assistant#17333: update to use DOMAIN constants and standards. (home-assistant#19242)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Fix race in entity_platform.async_add_entities (home-assistant#19222)
  Bumped version to 0.84.2
  Fix call to super() (home-assistant#19279)
  Fix OwnTracks deadlocking (home-assistant#19260)
  Fix list (fixes home-assistant#19235) (home-assistant#19258)
  Add automation and script events to logbook filter events (home-assistant#19253)
  Bump aioasuswrt (home-assistant#19229)
  Review comments
  Move check to websocket
  ...

@scop scop deleted the scop:huawei-lte-required-data branch Dec 14, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

huawei_lte: Fetch only required data (home-assistant#17618)
When debug logging is enabled, still fetch everything in order to
provide indication of available/supported data to users, as instructed
in docs.

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment