New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentherm_gw binary sensor support #17625

Merged
merged 2 commits into from Oct 20, 2018

Conversation

Projects
None yet
4 participants
@mvn23
Contributor

mvn23 commented Oct 19, 2018

Description:

Add binary sensor support to the OpenTherm Gateway component

Related issue (if applicable): ref. #16670

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6975

Example entry for configuration.yaml (if applicable):

opentherm_gw:
  device: /dev/ttyUSB0
  monitored_variables:
  - flame_on
  - slave_ch_active
  - slave_service_required
  - slave_water_overtemp
  - otgw_gpio_a_state

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@wafflebot wafflebot bot added the in progress label Oct 19, 2018

@mvn23 mvn23 referenced this pull request Oct 19, 2018

Merged

Add opentherm_gw binary_sensor docs #6975

2 of 2 tasks complete

@mvn23 mvn23 changed the title from Add OpenTherm Gateway binary sensor support. to Add opentherm_gw binary sensor support Oct 20, 2018

@MartinHjelmare

Shouldn't the binary_sensor entity be non polling?

Show resolved Hide resolved homeassistant/components/opentherm_gw.py
@mvn23

This comment has been minimized.

Contributor

mvn23 commented Oct 20, 2018

Should be non-polling indeed. Thanks for noticing!

@MartinHjelmare

Are the other platforms implemented as non polling?

@mvn23

This comment has been minimized.

Contributor

mvn23 commented Oct 20, 2018

After your comment I checked the climate and sensor platforms as well to make sure, they are both non-polling. Don't know how I missed it here...

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Oct 20, 2018

Good! Can be merged when build passes.

@mvn23

This comment has been minimized.

Contributor

mvn23 commented Oct 20, 2018

Awesome! I was already hoping to get this through for 0.81. Thanks for reviewing!

@MartinHjelmare MartinHjelmare merged commit 237ac08 into home-assistant:dev Oct 20, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 93.6%
Details

@wafflebot wafflebot bot removed the in progress label Oct 20, 2018

@mvn23 mvn23 deleted the mvn23:opentherm_gw branch Oct 24, 2018

@balloob balloob referenced this pull request Oct 26, 2018

Merged

0.81 #17809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment