New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate kodi media player progress bar #17626

Merged
merged 5 commits into from Nov 5, 2018

Conversation

Projects
None yet
5 participants
@vetegrodd
Contributor

vetegrodd commented Oct 19, 2018

Description:

Add necessary method calls for activating progress bar.

Related issue (if applicable): NA

Pull request in home-assistant.io with documentation (if applicable): NA

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@vetegrodd vetegrodd requested a review from armills as a code owner Oct 19, 2018

@homeassistant

This comment has been minimized.

homeassistant commented Oct 19, 2018

Hi @vetegrodd,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@cgtobi

This comment has been minimized.

Contributor

cgtobi commented Oct 29, 2018

Looks good to me.

def media_position_updated_at(self):
"""Last valid time of media position."""
if self.state in (STATE_PLAYING, STATE_PAUSED):
return dt_util.utcnow()

This comment has been minimized.

@armills

armills Oct 29, 2018

Member

This implementation will cause a state change with every update. This method must be implemented such that media_position_updated_at doesn't change unless the position has actually changed.

This comment has been minimized.

@vetegrodd

vetegrodd Oct 29, 2018

Contributor

I will fix that.

This comment has been minimized.

@vetegrodd

vetegrodd Oct 30, 2018

Contributor

I have updated the code and tested it locally now.

I was inspired by the VLC component.

vetegrodd added some commits Oct 19, 2018

@vetegrodd vetegrodd force-pushed the vetegrodd:kodi_progress branch from 634d80c to 0a83bce Oct 31, 2018

@armills

armills approved these changes Nov 5, 2018

Apologies for the delay here. We realized that VLC isn't doing exactly what we want either, but that's more of a larger refactoring we need to tackle. This matches what other platforms are currently doing, so it's good for now.

@armills armills merged commit b261c4b into home-assistant:dev Nov 5, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 93.093%
Details

@wafflebot wafflebot bot removed the in progress label Nov 5, 2018

@armills

This comment has been minimized.

Member

armills commented Nov 5, 2018

Thanks for the contribution! 🌟

@vetegrodd

This comment has been minimized.

Contributor

vetegrodd commented Nov 5, 2018

Thanks for a great product!

@vetegrodd vetegrodd deleted the vetegrodd:kodi_progress branch Nov 5, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment