New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary sensors for sense energy monitor #17645

Merged
merged 40 commits into from Nov 2, 2018

Conversation

@kbickar
Contributor

kbickar commented Oct 20, 2018

Description:

Added binary sensors for individual devices detected by sense energy monitor. Devices are either using power or off.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6983

Example entry for configuration.yaml (if applicable):

sense:
  email: <email>
  password: <password>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated

@kbickar kbickar referenced this pull request Oct 20, 2018

Merged

Updated to include new devices configuration #6983

2 of 2 tasks complete
@Danielhiversen

The code has to be split up in
components/sense.py
components/sensor/sense.py
components/binary_sensor/sense.py

Check the documentation: https://developers.home-assistant.io/docs/en/creating_component_index.html

Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py Outdated

kbickar added some commits Oct 23, 2018

@kbickar

Refactored this pull request quite a bit - these are all resolved

@Danielhiversen

Nice work. Some comments

Show resolved Hide resolved homeassistant/components/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py

kbickar added some commits Nov 1, 2018

kbickar added some commits Nov 1, 2018

@kbickar

This comment has been minimized.

Contributor

kbickar commented Nov 1, 2018

Rearranged again so now all the sensors get added automatically with discovery instead of configuration

kbickar added some commits Nov 1, 2018

@balloob

balloob approved these changes Nov 1, 2018

Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/sense.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/sense.py Outdated
@MartinHjelmare

Can be merged when build passes.

@balloob balloob merged commit 6eba7c4 into home-assistant:dev Nov 2, 2018

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.5%) to 93.059%
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Nov 2, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

@claytonjn claytonjn referenced this pull request Nov 17, 2018

Merged

Reflect changes in Sense configuration #7558

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment