Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mill, support more heater types #17676

Merged
merged 2 commits into from Oct 22, 2018
Merged

Mill, support more heater types #17676

merged 2 commits into from Oct 22, 2018

Conversation

Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Oct 21, 2018 •
edited

Description:

Mill, support more heater types

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned Danielhiversen Oct 21, 2018
@ghost ghost added the in progress label Oct 21, 2018
@Danielhiversen Danielhiversen mentioned this pull request Oct 21, 2018
Merged
2 tasks
MartinHjelmare
MartinHjelmare reviewed Oct 21, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rooms don't seem to be used yet.

@MartinHjelmare
Copy link
Member

Nevermind, I see the rooms have heaters too.

@Danielhiversen
Copy link
Member Author

Yes, the API requires two endpoints to get all the heaters.

@MartinHjelmare MartinHjelmare merged commit 61a96ae into dev Oct 22, 2018
@ghost ghost removed the in progress label Oct 22, 2018
@balloob balloob mentioned this pull request Nov 9, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels
cla-signed Hacktoberfest integration: mill small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Danielhiversen @MartinHjelmare @bachya @homeassistant