New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mill, support more heater types #17676

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
4 participants
@Danielhiversen
Member

Danielhiversen commented Oct 21, 2018

Description:

Mill, support more heater types

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Danielhiversen added some commits Oct 21, 2018

@MartinHjelmare

Rooms don't seem to be used yet.

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Oct 21, 2018

Nevermind, I see the rooms have heaters too.

@Danielhiversen

This comment has been minimized.

Member

Danielhiversen commented Oct 22, 2018

Yes, the API requires two endpoints to get all the heaters.

@MartinHjelmare MartinHjelmare merged commit 61a96ae into dev Oct 22, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.601%
Details

@wafflebot wafflebot bot removed the in progress label Oct 22, 2018

@Danielhiversen Danielhiversen deleted the mill branch Oct 23, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment