New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elk-M1 climate #17679

Merged
merged 4 commits into from Oct 24, 2018

Conversation

@gwww
Contributor

gwww commented Oct 21, 2018

Description:

New platform.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7000

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

gwww added some commits Oct 20, 2018

def supported_features(self):
"""Return the list of supported features."""
return (SUPPORT_OPERATION_MODE | SUPPORT_FAN_MODE | SUPPORT_AUX_HEAT
SUPPORT_TARGET_TEMPERATURE_HIGH | SUPPORT_TARGET_TEMPERATURE_LOW)

This comment has been minimized.

@houndci-bot

houndci-bot Oct 21, 2018

SyntaxError: invalid syntax
continuation line under-indented for visual indent

@gwww gwww referenced this pull request Oct 21, 2018

Merged

Add documentation for Open Elk-M1 climate #7000

2 of 2 tasks complete

gwww added some commits Oct 21, 2018

@balloob balloob added this to the 0.81 milestone Oct 24, 2018

@balloob

This comment has been minimized.

Member

balloob commented Oct 24, 2018

Tagged for 81 so we won't remove functionality.

@balloob balloob merged commit 6ac9677 into home-assistant:dev Oct 24, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.601%
Details

@wafflebot wafflebot bot removed the in progress label Oct 24, 2018

balloob added a commit that referenced this pull request Oct 24, 2018

Elk-M1 climate (#17679)
* Initial climate for Elk-M1.

* Tidy

* fix hound error

* fix hound error

@gwww gwww deleted the gwww:elkm1-climate branch Oct 25, 2018

@balloob balloob referenced this pull request Oct 26, 2018

Merged

0.81 #17809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment