New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable config flow for Luftdaten #17700

Merged
merged 14 commits into from Nov 6, 2018

Conversation

@fabaff
Member

fabaff commented Oct 22, 2018

Description:

Enable the configuration of Luftdaten stations through the frontend.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7393

Example entry for configuration.yaml (if applicable):

luftdaten:
  sensor_id: SENSOR_ID
  sensors:
    - p1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare

Didn't look at the tests.

Show resolved Hide resolved homeassistant/components/luftdaten/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/luftdaten/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/luftdaten/config_flow.py Outdated
Show resolved Hide resolved homeassistant/components/luftdaten/config_flow.py Outdated
Show resolved Hide resolved homeassistant/components/luftdaten/config_flow.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/luftdaten.py Outdated

@fabaff fabaff force-pushed the luftdaten branch from 1765ba5 to 474ab9f Oct 26, 2018

@fabaff fabaff force-pushed the luftdaten branch from 474ab9f to 90fe860 Nov 3, 2018

fabaff added some commits Oct 9, 2018

@fabaff fabaff force-pushed the luftdaten branch from 90fe860 to 873c007 Nov 4, 2018

fabaff added some commits Nov 5, 2018

Fix
@MartinHjelmare

Looks good! I think we can merge when tests pass.

Show resolved Hide resolved homeassistant/components/luftdaten/config_flow.py Outdated
Show resolved Hide resolved homeassistant/components/luftdaten/config_flow.py Outdated
Show resolved Hide resolved homeassistant/components/luftdaten/config_flow.py Outdated

@fabaff fabaff referenced this pull request Nov 6, 2018

Merged

Update Luftdaten docs #7393

2 of 2 tasks complete
@fabaff

This comment has been minimized.

Member

fabaff commented Nov 6, 2018

Breaking change:

The luftdaten integration was migrated to be a component and allow the configuration through the frontend. If you are using the luftdaten sensor, please update your entry in your configuration.yaml file.

@fabaff fabaff merged commit 2e517ab into dev Nov 6, 2018

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.056%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

@fabaff fabaff deleted the luftdaten branch Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Enable config flow for Luftdaten (home-assistant#17700)
* Move file to new location

* Update requirement

* Enable config flow

* Add luftdaten

* Add tests

* Update

* Add constants

* Changes according to the review comments

* Remove wrong entry from flows

* Fix dict handling

* Add callback and use OrderedDict

* Remve leftover

* Fix

* Remove await

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

@nikolaykasyanov

This comment has been minimized.

Contributor

nikolaykasyanov commented Dec 2, 2018

Luftdaten sensors are no longer exposed to HomeKit after this change.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Dec 2, 2018

@balloob

This comment has been minimized.

Member

balloob commented Dec 2, 2018

No issue reporting on PRs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.