New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contact sensors to alexa smart home #17704

Merged
merged 6 commits into from Oct 25, 2018

Conversation

Projects
None yet
5 participants
@abmantis
Contributor

abmantis commented Oct 22, 2018

Related issue (if applicable): fixes some part of #17628 (motion sensors in another PR).

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

abmantis added some commits Oct 22, 2018

assert properties['retrievable'] is True
assert {'name': 'detectionState'} in properties['supported']
properties = yield from reported_properties(hass, 'binary_sensor#test_contact')

This comment has been minimized.

@houndci-bot

houndci-bot Oct 22, 2018

line too long (83 > 79 characters)

abmantis added some commits Oct 23, 2018

@abmantis abmantis force-pushed the abmantis:alexa_contact_sensors branch from acaf985 to fb88829 Oct 23, 2018

@abmantis abmantis changed the title from [WIP] Add contact sensors to alexa smart home to Add contact sensors to alexa smart home Oct 23, 2018

@pvizeli pvizeli merged commit 9c7d3c2 into home-assistant:dev Oct 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.589%
Details

@wafflebot wafflebot bot removed the in progress label Oct 25, 2018

@abmantis abmantis deleted the abmantis:alexa_contact_sensors branch Oct 25, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment