New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unavailable property when issue retrieving August information #17706

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@ehendrix23
Contributor

ehendrix23 commented Oct 23, 2018

Description:

Sets the unavailable property for the entity if there is an issue when trying to retrieve the status for the August lock, sensor, and/or doorbells.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
Set available property
Will set the available property to False if unable to communicate with August lock or doorbell.
HTTP request errors (i.e. timeout, connection error, HTTP error) will not result in traceback. Instead an error will be logged.

@ehendrix23 ehendrix23 force-pushed the ehendrix23:Set-unavailable-property branch from 57980ee to 37ca20b Oct 23, 2018

@balloob

This comment has been minimized.

Member

balloob commented Oct 23, 2018

Nice 👍

@balloob balloob merged commit 4a757b7 into home-assistant:dev Oct 23, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 93.596%
Details

@wafflebot wafflebot bot removed the in progress label Oct 23, 2018

@ehendrix23 ehendrix23 deleted the ehendrix23:Set-unavailable-property branch Oct 27, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment