New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename readthedocs file #17718

Merged
merged 2 commits into from Oct 23, 2018

Conversation

Projects
None yet
5 participants
@fabaff
Member

fabaff commented Oct 23, 2018

Description:

The new configuration was introduced with #17642. This change rename the file to make it more clear that's a configuration file.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

fabaff added some commits Oct 23, 2018

@wafflebot wafflebot bot added the in progress label Oct 23, 2018

@MartinHjelmare MartinHjelmare changed the title from Rename file to Rename readthedocs file Oct 23, 2018

@balloob

This comment has been minimized.

Member

balloob commented Oct 23, 2018

Is this format supported?

@rohankapoorcom

This comment has been minimized.

Contributor

rohankapoorcom commented Oct 23, 2018

Doesn't look it, per the docs, it must be readthedocs.yml in the root of the project.

However, the regex they are using does allow the filename to have a dot prefix. I tested the regex really fast and it does validate the proposed file name.

@balloob balloob merged commit f997369 into dev Oct 23, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.584%
Details

@wafflebot wafflebot bot removed the in progress label Oct 23, 2018

@balloob balloob deleted the rtd branch Oct 23, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment