New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webhook_id from yaml config for mailgun #17732

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
4 participants
@rohankapoorcom
Contributor

rohankapoorcom commented Oct 23, 2018

Description:

In #17464, I migrated Mailgun to use the webhook component. While doing that, I accidentally added the webhook_id as a yaml configuration option (in addition to it being handled by the configuration entry system. This needs to be removed as the component will never actually use it. This behavior was never documented (and not released yet) so no documentation changes should be needed.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Oct 24, 2018

🐦

@fabaff fabaff merged commit a10fb94 into home-assistant:dev Oct 24, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 93.589%
Details

@wafflebot wafflebot bot removed the in progress label Oct 24, 2018

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:mailgun-config-webhooks branch Oct 24, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment