New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert auth websocket commands to use async_response decorator #17755

merged 1 commit into from Oct 24, 2018


None yet
4 participants

balloob commented Oct 24, 2018


Realized that the auth websocket commands don't use async_response decorator but are async. Means we could end up with losing exceptions. This simply converts them.


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Oct 24, 2018

@wafflebot wafflebot bot added the in progress label Oct 24, 2018

@pvizeli pvizeli merged commit c7c0ed8 into dev Oct 24, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
coverage/coveralls Coverage decreased (-0.0007%) to 93.555%

@wafflebot wafflebot bot removed the in progress label Oct 24, 2018

@pvizeli pvizeli deleted the auth-async-response branch Oct 24, 2018

@balloob balloob referenced this pull request Nov 9, 2018


0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment