New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating signed urls #17759

Merged
merged 3 commits into from Oct 25, 2018

Conversation

@balloob
Member

balloob commented Oct 24, 2018

Description:

Allow creating signed urls to allow GET requests with authorization. (GET requests can't have headers attached in browsers, ie a link).

Will be used to download snapshots in Hass.io

Docs: home-assistant/developers.home-assistant#132 (preview)

Related issue (if applicable): fixes #16745

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Oct 24, 2018

@wafflebot wafflebot bot added the in progress label Oct 24, 2018

assert data['user_id'] == refresh_token.user.id

# Use signature on other path
req = await client.get('/another_path?{}'.format(signed_path.split('?')[1]))

This comment has been minimized.

@houndci-bot

houndci-bot Oct 24, 2018

line too long (80 > 79 characters)

@balloob balloob force-pushed the auth-signed-url branch from 92a19a0 to c0b7da5 Oct 24, 2018

@balloob balloob force-pushed the auth-signed-url branch from 78f25a3 to 4563ed8 Oct 24, 2018

@balloob balloob changed the title from Allow creating signed urls to WIP: Allow creating signed urls Oct 24, 2018

@balloob balloob changed the title from WIP: Allow creating signed urls to Allow creating signed urls Oct 24, 2018

@balloob balloob referenced this pull request Oct 24, 2018

Merged

Add docs for signed path #132

@pvizeli pvizeli merged commit 312d49c into dev Oct 25, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 93.556%
Details

@pvizeli pvizeli deleted the auth-signed-url branch Oct 25, 2018

@wafflebot wafflebot bot removed the in progress label Oct 25, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment