New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making MQTT fan tests async #17761

Merged
merged 1 commit into from Oct 28, 2018

Conversation

Projects
None yet
6 participants
@kennedyshead
Contributor

kennedyshead commented Oct 24, 2018

Description:

To migrate restore_state (PR #17270) to use the storage helper instead of history, we need to migrate all tests for components/platforms that use restore state to async or else the pytest fixtures won't work.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Oct 24, 2018

@kennedyshead kennedyshead changed the title from Making MQtt fan tests async to Making MQTT fan tests async Oct 24, 2018

@kennedyshead kennedyshead force-pushed the kennedyshead:MQTT_async_tests branch from 33941a6 to 45a4058 Oct 25, 2018

@kennedyshead kennedyshead force-pushed the kennedyshead:MQTT_async_tests branch from 45a4058 to b6ff1d5 Oct 26, 2018

@fabaff fabaff merged commit 3802fec into home-assistant:dev Oct 28, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.238%
Details

@wafflebot wafflebot bot removed the in progress label Oct 28, 2018

@kennedyshead kennedyshead deleted the kennedyshead:MQTT_async_tests branch Oct 31, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment