New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mqtt json asnync tested #17768

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
5 participants
@kennedyshead
Contributor

kennedyshead commented Oct 24, 2018

Description:

To migrate restore_state (PR #17270) to use the storage helper instead of history, we need to migrate all tests for components/platforms that use restore state to async or else the pytest fixtures won't work.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Oct 24, 2018

@kennedyshead kennedyshead force-pushed the kennedyshead:light_mqtt_json_asnync_tested branch from e748284 to 1ef4f9f Oct 24, 2018

@balloob

Awesome work!

This one and the MQTT template light are the most important, as those are using the restore state. I first thought all MQTT were using it, but luckily not yet.

@kennedyshead

This comment has been minimized.

Contributor

kennedyshead commented Oct 25, 2018

Well, its great to move it to async anyway ;)

Ill sort this one now!

@kennedyshead kennedyshead force-pushed the kennedyshead:light_mqtt_json_asnync_tested branch from 1ef4f9f to 3e175f9 Oct 25, 2018

@balloob balloob merged commit 8bebfba into home-assistant:dev Oct 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 93.396%
Details

@wafflebot wafflebot bot removed the in progress label Oct 25, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment