New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fan should be interpreted as Fan in Google Assistant #17792

Merged
merged 1 commit into from Oct 28, 2018

Conversation

Projects
None yet
6 participants
@mariuszluciow
Contributor

mariuszluciow commented Oct 25, 2018

Description:

Google has a separate type for Fan devices.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Oct 25, 2018

@mariuszluciow mariuszluciow changed the title from Google assistant/fan to WIP Google assistant/fan Oct 25, 2018

@mariuszluciow mariuszluciow force-pushed the mariuszluciow:google-assistant/fan branch from d0a53ec to 65ae04e Oct 25, 2018

@mariuszluciow mariuszluciow changed the title from WIP Google assistant/fan to WIP Fan should be interpreted as Fan in Google Assistant Oct 25, 2018

@mariuszluciow mariuszluciow force-pushed the mariuszluciow:google-assistant/fan branch from 65ae04e to abdf5e9 Oct 25, 2018

@michaelarnauts

This comment has been minimized.

Contributor

michaelarnauts commented Oct 25, 2018

This PR is about vacuum. You want to split that into a different PR.

@mariuszluciow

This comment has been minimized.

Contributor

mariuszluciow commented Oct 26, 2018

@michaelarnauts waiting for #17657 to be merged first, to avoid conflicts.

@balloob

This comment has been minimized.

Member

balloob commented Oct 26, 2018

okay, other one is merged, please rebase.

@mariuszluciow mariuszluciow force-pushed the mariuszluciow:google-assistant/fan branch from abdf5e9 to 14f37f6 Oct 27, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@mariuszluciow mariuszluciow force-pushed the mariuszluciow:google-assistant/fan branch from 14f37f6 to 5c0f645 Oct 27, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@mariuszluciow mariuszluciow changed the title from WIP Fan should be interpreted as Fan in Google Assistant to Fan should be interpreted as Fan in Google Assistant Oct 27, 2018

@mariuszluciow

This comment has been minimized.

Contributor

mariuszluciow commented Oct 27, 2018

@balloob rebased

@balloob balloob merged commit 38576e5 into home-assistant:dev Oct 28, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0002%) to 93.226%
Details

@wafflebot wafflebot bot removed the in progress label Oct 28, 2018

@balloob

This comment has been minimized.

Member

balloob commented Oct 28, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment