New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert automation tests to async #17794

Merged
merged 3 commits into from Oct 26, 2018

Conversation

Projects
None yet
4 participants
@balloob
Member

balloob commented Oct 25, 2018

Description:

Part of converting certain tests to async for restoration effort in #17270.

This is most of the automation components.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
assert 2 == len(calls)
async def test_if_fires_on_entity_change_with_for_attribute_change(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (80 > 79 characters)

assert 0 == len(calls)
async def test_if_not_fires_on_entities_change_with_for_after_stop(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (80 > 79 characters)

calls[0].data['some']
async def test_not_fires_on_attr_change_with_attr_not_below_multiple_attr(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (87 > 79 characters)

assert 0 == len(calls)
async def test_fires_on_attr_change_with_attribute_below_and_multiple_attr(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (88 > 79 characters)

assert 0 == len(calls)
async def test_if_not_fires_on_entity_change_with_not_attribute_below(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (83 > 79 characters)

assert 1 == len(calls)
async def test_if_not_fires_on_entity_change_not_below_with_attribute(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (83 > 79 characters)

assert 1 == len(calls)
async def test_if_fires_on_entity_change_over_to_below_above_range(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (80 > 79 characters)

assert 1 == len(calls)
async def test_if_fires_on_entity_change_with_for_multiple_force_update(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (85 > 79 characters)

assert 2 == len(calls)
async def test_if_fires_on_entity_change_with_for_attribute_change(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (80 > 79 characters)

assert 0 == len(calls)
async def test_if_not_fires_on_entities_change_with_for_after_stop(hass, calls):

This comment has been minimized.

@houndci-bot

houndci-bot Oct 25, 2018

line too long (80 > 79 characters)

@balloob balloob merged commit e276e89 into dev Oct 26, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.273%
Details

@wafflebot wafflebot bot removed the in progress label Oct 26, 2018

@balloob balloob deleted the async-automation-tests branch Oct 26, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment