New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass though file_url from extended data attrs #17801

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
7 participants
@cmsimike
Contributor

cmsimike commented Oct 26, 2018

Description:

Pass through file_url to the Synology chat API so that it can send attachments in Synology Chat.

Related issue (if applicable): fixes #17748

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7100

Example entry for configuration.yaml (if applicable):

notify:
  - platform: synology_chat
    name: hass_synchat_name
    resource: https://synology.example.com/webapi/entry.cgi?api=SYNO.Chat.External&method=incoming&version=1&token=foobar

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@@ -43,6 +44,12 @@ def send_message(self, message="", **kwargs):
'text': message
}
extended_data = kwargs.get(ATTR_DATA)
file_url = extended_data.get(ATTR_FILE_URL, None) if extended_data else None

This comment has been minimized.

@houndci-bot

houndci-bot Oct 26, 2018

line too long (84 > 79 characters)

from homeassistant.const import CONF_RESOURCE
import homeassistant.helpers.config_validation as cv
ATTR_FILE_URL = 'file_url'

This comment has been minimized.

@houndci-bot

houndci-bot Oct 26, 2018

multiple spaces after operator

@cmsimike cmsimike referenced this pull request Oct 26, 2018

Merged

Update Synology Chat docs #7100

2 of 2 tasks complete

@cmsimike cmsimike changed the title from WIP: Pass though file_url from extended data attrs so synology chat bot ca… to Pass though file_url from extended data attrs so synology chat bot ca… Oct 26, 2018

@cmsimike

This comment has been minimized.

Contributor

cmsimike commented Oct 26, 2018

I don't know why this is stuck as WIP but I have removed that

@fabaff fabaff changed the title from Pass though file_url from extended data attrs so synology chat bot ca… to Pass though file_url from extended data attrs Oct 26, 2018

@heytensai heytensai referenced this pull request Oct 27, 2018

Merged

Add option to manually specify device detection method #7145

2 of 2 tasks complete
@fabaff

fabaff approved these changes Nov 1, 2018

Looks good to me 🐦

@fabaff fabaff merged commit afc109a into home-assistant:dev Nov 1, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.273%
Details

@wafflebot wafflebot bot removed the in progress label Nov 1, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

@xbmcnut

This comment has been minimized.

xbmcnut commented Dec 3, 2018

This has now broken in 0.83.x. Messages with file_url: in code do not get sent at all. Was working great in 0.82.x

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Dec 3, 2018

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Dec 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.