New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NDMS2 client to 0.0.5 to fix unicode characters support #17803

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
4 participants
@foxel
Contributor

foxel commented Oct 26, 2018

Description:

NDMS2 client version 0.0.4 fails if user names device with unicode names, e.g. Cyrillic chars.
Fixed in 0.0.5: foxel/python_ndms2_client#1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@wafflebot wafflebot bot added the in progress label Oct 26, 2018

@foxel foxel changed the title from Bumped NDMS2 client to 0.0.5 to fix unicode characters support to Bump NDMS2 client to 0.0.5 to fix unicode characters support Oct 26, 2018

@fabaff

fabaff approved these changes Oct 26, 2018

Thanks 🐦

@fabaff fabaff merged commit 9e33398 into home-assistant:dev Oct 26, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 93.27%
Details

@wafflebot wafflebot bot removed the in progress label Oct 26, 2018

@foxel foxel deleted the foxel:bump_ndms_version_0.0.5 branch Oct 26, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment