New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete sensor.yahoo_finance #17805

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@rohankapoorcom
Contributor

rohankapoorcom commented Oct 26, 2018

Description:

This sensor hasn't worked for 1 year because yahoo deleted their web finance API. We should remove the code and tests for it since it's an unusable platform.

Breaking Change: The sensor.yahoo_finance platform has been deleted.

Related issue (if applicable): fixes #17789

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7107

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Oct 26, 2018

🐦

@fabaff fabaff merged commit b7b62a9 into home-assistant:dev Oct 26, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.008%) to 93.264%
Details

@wafflebot wafflebot bot removed the in progress label Oct 26, 2018

@rohankapoorcom

This comment has been minimized.

Contributor

rohankapoorcom commented Oct 26, 2018

@fabaff Should we apply the "Breaking Change" label?

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:delete-yahoo-finance branch Oct 26, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment