New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions improv #17811

merged 5 commits into from Oct 29, 2018


None yet
4 participants

balloob commented Oct 26, 2018


Fixes all my blockers before we can start enforcing it.

  • break up permissions into multiple files, as it will grow
  • allow specifying more granular permissions for entities: read, control, edit
  • add "all" subcategory to entities, so that we can apply granular controls to all entities.

Pull request in with documentation (if applicable): home-assistant/< PR number goes here>


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
assert perm.filter_states(states) == states

This comment has been minimized.


houndci-bot Oct 26, 2018

blank line at end of file

OwnerPermissions = _OwnerPermissions() # pylint: disable=invalid-name

This comment has been minimized.


houndci-bot Oct 26, 2018

blank line at end of file

balloob added some commits Oct 26, 2018

@balloob balloob force-pushed the permissions-improv branch from 971942a to 72fdf9f Oct 26, 2018

@balloob balloob merged commit f4ac317 into dev Oct 29, 2018

5 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
coverage/coveralls Coverage increased (+0.0008%) to 93.239%

@wafflebot wafflebot bot removed the in progress label Oct 29, 2018

@balloob balloob deleted the permissions-improv branch Oct 29, 2018

@balloob balloob referenced this pull request Nov 9, 2018


0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment