New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mill device state attributes #17834

merged 2 commits into from Oct 27, 2018


None yet
5 participants

Danielhiversen commented Oct 26, 2018


  • Mill device state attributes


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/
  • New files were added to .coveragerc.
room =
room = "Independent device"
return {"Room": room,

This comment has been minimized.


MartinHjelmare Oct 26, 2018


Please make the keys lowercase snakecase. That's our standard.


Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@Danielhiversen Danielhiversen merged commit 21870e2 into dev Oct 27, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
coverage/coveralls Coverage decreased (-0.0009%) to 93.226%

@wafflebot wafflebot bot removed the in progress label Oct 27, 2018

@Danielhiversen Danielhiversen deleted the mill_att branch Oct 27, 2018

@balloob balloob referenced this pull request Nov 9, 2018


0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment