New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to manually specify device detection method #17852

Merged
merged 2 commits into from Nov 3, 2018

Conversation

Projects
None yet
4 participants
@heytensai
Contributor

heytensai commented Oct 27, 2018

Description:

Mikrotik module automatically detects whether to use wireless, capsman, or dhcp for device detection. If a Mikrotik router has wireless but the use prefers to use dhcp, this new option allows the user to force a specific method.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7145

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: mikrotik
    host: IP_ADDRESS
    username: ADMIN_USERNAME
    password: ADMIN_PASSWORD
    method: ip

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@homeassistant

This comment has been minimized.

homeassistant commented Oct 27, 2018

Hi @heytensai,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@homeassistant homeassistant added cla-signed and removed cla-needed labels Oct 27, 2018

@heytensai heytensai referenced this pull request Oct 27, 2018

Merged

Add option to manually specify device detection method #7145

2 of 2 tasks complete
@fabaff

fabaff approved these changes Nov 3, 2018

Looks good to me 🐦

@fabaff fabaff merged commit 155df91 into home-assistant:dev Nov 3, 2018

4 of 5 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 93.065%
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Nov 3, 2018

WoLpH added a commit to WoLpH/home-assistant that referenced this pull request Nov 14, 2018

Made `method` setting optional as intended
Pull request home-assistant#17852 accidently made the `method` setting required.

@WoLpH WoLpH referenced this pull request Nov 14, 2018

Merged

Make mikrotik method setting optional as intended #18454

3 of 3 tasks complete

MartinHjelmare added a commit that referenced this pull request Nov 14, 2018

Make mikrotik method setting optional as intended (#18454)
Pull request #17852 accidently made the `method` setting required.

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment