New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a list ofr update entity #17860

Merged
merged 3 commits into from Oct 27, 2018

Conversation

Projects
None yet
4 participants
@balloob
Member

balloob commented Oct 27, 2018

Description:

Our data validation was a bit too strict on update entity. We would not allow a list with a single entity. This updates the service to take any number of entities.

Related issue (if applicable): fixes #17851

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

balloob added some commits Oct 27, 2018

@balloob balloob added this to the 0.81.1 milestone Oct 27, 2018

@wafflebot wafflebot bot added the in progress label Oct 27, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@@ -527,6 +527,12 @@ homeassistant:
entity_id:
description: The entity_id of the device to turn off.
example: light.living_room
update_entity:
description: Force one or more entities to update it's data

This comment has been minimized.

@amelchio

amelchio Oct 27, 2018

Member

"its data"

@amelchio

Looks good.

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob merged commit 649bc55 into dev Oct 27, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 93.226%
Details

@wafflebot wafflebot bot removed the in progress label Oct 27, 2018

@balloob balloob deleted the allow-list-update-entity branch Oct 27, 2018

balloob added a commit that referenced this pull request Oct 27, 2018

Allow a list ofr update entity (#17860)
* Allow a list ofr update entity

* Update services.yaml

* Update services.yaml

@balloob balloob referenced this pull request Oct 27, 2018

Merged

0.81.1 #17895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment