New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for upnp-component/#17753 and missing hass-data when only setup from config entry #17868

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
5 participants
@StevenLooman
Contributor

StevenLooman commented Oct 27, 2018

Description:

Fix traceback in #17753 by upgrading to async_upnp_client==0.13.0.
Also fix a traceback when a upnp-config entry is set up, but the main upnp-platform is not. local_ip was missing, but expected.

Related issue (if applicable): fixes #17753

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@StevenLooman StevenLooman changed the title from Igd fixed to Fixes for upnp-component/#17753 and missing hass-data when only setup from config entry Oct 27, 2018

@StevenLooman

This comment has been minimized.

Contributor

StevenLooman commented Oct 27, 2018

@dgomes

dgomes approved these changes Oct 27, 2018

LGTM

@balloob balloob merged commit 96c5e4c into home-assistant:dev Oct 29, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0002%) to 93.226%
Details

@wafflebot wafflebot bot removed the Ready for review label Oct 29, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment