New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Client from twilio.rest rather than the deleted TwiloRestClient #17883

Merged
merged 1 commit into from Oct 27, 2018

Conversation

Projects
None yet
4 participants
@rohankapoorcom
Contributor

rohankapoorcom commented Oct 27, 2018

Description:

Twilio changed the class that needs to be used from TwilioRestClient to Client. Source.

This broke after the twilio client was upgraded in #17424 and an API change was missed.

Related issue (if applicable): fixes #17871

This one is affecting 0.81 and should be shipped in the next bugfix release. However, I'm not sure how to do that since the component itself was rewritten in #17715 (so the files are not in the same place). This pull request is targeted at dev for release with 0.82.0 and #17885 is targeted at master in case that helps for the hotfix for 0.81.x.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob merged commit d6e4208 into home-assistant:dev Oct 27, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.005%) to 93.221%
Details

@wafflebot wafflebot bot removed the in progress label Oct 27, 2018

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:twilio-client-change-dev branch Oct 27, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment