New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Client from twilio.rest rather than the deleted TwillioRestClient #17885

Merged
merged 2 commits into from Oct 27, 2018

Conversation

Projects
None yet
5 participants
@rohankapoorcom
Contributor

rohankapoorcom commented Oct 27, 2018

Description:

Twilio changed the class that needs to be used from TwilioRestClient to Client. Source.

This broke after the twilio client was upgraded in #17424 and an API change was missed.

Related issue (if applicable): fixes #17871

This one is affecting 0.81.x and should be shipped in the next bugfix release. However, I'm not sure how to do that since the component itself was rewritten in #17715 (so the files are not in the same place in dev and master). This pull request is targeted at master in case that helps for the hotfix and #17883 is targeted at dev which should fix it for 0.82.0

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

balloob and others added some commits Oct 26, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@bachya

This comment has been minimized.

Contributor

bachya commented Oct 27, 2018

Make sure to base your PR against dev, not master.

@rohankapoorcom

This comment has been minimized.

Contributor

rohankapoorcom commented Oct 27, 2018

@bachya please read the last paragraph before the checklist. There's one pull request against master and another against dev because the code got moved around in dev and we need to hotfix the release as well as fix dev.

Please let me know if there's a better approach for this.

@balloob balloob changed the base branch from master to rc Oct 27, 2018

@balloob

This comment has been minimized.

Member

balloob commented Oct 27, 2018

Changing to RC. Will probably be nasty when we merge master back in to dev, but we'll survive.

@balloob balloob merged commit a0d4595 into home-assistant:rc Oct 27, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.567%
Details

@wafflebot wafflebot bot removed the in progress label Oct 27, 2018

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:twilio-client-change-master branch Oct 27, 2018

@rohankapoorcom

This comment has been minimized.

Contributor

rohankapoorcom commented Oct 27, 2018

Thanks! I'm expecting it to be annoying, but couldn't think of a way to avoid it. Let me know if I can help with the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment