New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lovelace: Move migrate to separate WS command #17890

Merged
merged 1 commit into from Oct 27, 2018

Conversation

Projects
None yet
4 participants
@balloob
Member

balloob commented Oct 27, 2018

Description:

Move Lovelace migration to a separate WS command, to be called by UI after confirming with the user.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.81.1 milestone Oct 27, 2018

@balloob balloob requested a review from home-assistant/core as a code owner Oct 27, 2018

@wafflebot wafflebot bot added the in progress label Oct 27, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob referenced this pull request Oct 27, 2018

Merged

Adding id to lovelace cards in ui-lovelace.yaml #17498

6 of 8 tasks complete
@zsarnett

This comment has been minimized.

zsarnett commented Oct 27, 2018

I believe this is a good compromise. Will this auto set new users up UI Editing? I think asking current users is a good idea as it would change the way they currently write their files. But new users should have to opt out as we want to push users to use the UI editor

@balloob

This comment has been minimized.

Member

balloob commented Oct 27, 2018

This will set up new users automatically, as they have no cards, so no cards that need IDs

@balloob balloob merged commit 9cd8a86 into dev Oct 27, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 93.196%
Details

@wafflebot wafflebot bot removed the in progress label Oct 27, 2018

@balloob balloob deleted the migrate-lovelace branch Oct 27, 2018

balloob added a commit that referenced this pull request Oct 27, 2018

@balloob balloob referenced this pull request Oct 27, 2018

Merged

0.81.1 #17895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment