New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vera climate component to use correct states #17892

Merged
merged 1 commit into from Oct 28, 2018

Conversation

Projects
None yet
5 participants
@sqldiablo
Contributor

sqldiablo commented Oct 27, 2018

Description:

Changed the Vera climate component so it uses the STATE_* states from the base climate component. This will allow it to work with Google Assistant.

Related issue (if applicable): fixes #17302

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
Fix Vera climate component to use correct states
Changed the Vera climate component so it uses the STATE_* states from the base climate component. This will allow it to work with Google Assistant.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@sqldiablo

This comment has been minimized.

Contributor

sqldiablo commented Oct 27, 2018

@awarecan: I'm not sure if you have approval authority, but can you look this over for me? I'm testing it locally, and the thermostat works fine and Google Assistant is able to control it/query it, set modes, and set temperatures.

@balloob

Looks great!

@balloob balloob merged commit cbadd64 into home-assistant:dev Oct 28, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.005%) to 93.221%
Details

@wafflebot wafflebot bot removed the in progress label Oct 28, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment