New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor all sensor types by default to rtorrent #17894

Merged
merged 4 commits into from Oct 28, 2018

Conversation

Projects
None yet
6 participants
@terorie
Contributor

terorie commented Oct 27, 2018

Description:

After merging #17421, @MartinHjelmare commented:

I just realised that this shouldn't have an empty list as default if this config option is optional. Either have it be optional and default to all conditions, or make it required and remove default.

This PR adds all three sensor types to monitored_variables, if the user omits the field in the configuration.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@terorie terorie referenced this pull request Oct 27, 2018

Merged

Add new rtorrent sensor #17421

7 of 7 tasks complete
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@MartinHjelmare

Great, thanks!

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Oct 27, 2018

Can be merged when build passes.

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@fabaff fabaff changed the title from rtorrent.py: Monitor all sensor types by default to Monitor all sensor types by default to rtorrent Oct 28, 2018

@terorie

This comment has been minimized.

Contributor

terorie commented Oct 28, 2018

Travis CI builds are stuck again :/

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Oct 28, 2018

I cancelled and restarted.

@terorie

This comment has been minimized.

Contributor

terorie commented Oct 28, 2018

Thanks, but it still seems to be stuck on Created 🤔
Let's just wait it out.

@fabaff fabaff merged commit b62b3b2 into home-assistant:dev Oct 28, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 93.197%
Details

@wafflebot wafflebot bot removed the in progress label Oct 28, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment