New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract entity ids from all templates #17902

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
4 participants
@amelchio
Member

amelchio commented Oct 28, 2018

Description:

The template binary sensor did not extract entity ids to watch from all of its templates. This was hidden because the tests for icon/entity_picture used a value_template that would match all states.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@amelchio amelchio force-pushed the amelchio:binary-sensor-template-extract-all-templates branch from 52a33dd to 35df43f Oct 28, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@amelchio amelchio force-pushed the amelchio:binary-sensor-template-extract-all-templates branch from 35df43f to 262e28f Oct 28, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@balloob

We should update this platform to also not watch all

@balloob balloob merged commit e5c97fd into home-assistant:dev Oct 29, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on binary-sensor-template-extract-all-templates at 93.192%
Details

@wafflebot wafflebot bot removed the in progress label Oct 29, 2018

@amelchio

This comment has been minimized.

Member

amelchio commented Oct 29, 2018

Yes, that's how I found this issue 😃

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment