New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logi_circle sensor update method naming #17909

merged 1 commit into from Oct 28, 2018


None yet
4 participants

evanjd commented Oct 28, 2018


The logi_circle sensor component's update method has the incorrect name. It should be async_update, instead of update.

Because 0.81 now calls the update method with async_add_executor_job, the sensor update method now fails (coroutines cannot be used with run_in_executor()).

Sorry for missing this in my original PR!

Related issue (if applicable): fixes #17908


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
Fix logi_circle sensor update method naming
Resolves regression in 0.81

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

evanjd added a commit to evanjd/hass-logi-circle that referenced this pull request Oct 28, 2018


fabaff approved these changes Oct 28, 2018

Thanks 🐦

@fabaff fabaff merged commit 6cb7352 into home-assistant:dev Oct 28, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Hound No violations found. Woof!
WIP Legacy commit status override — see details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Oct 28, 2018

@balloob balloob referenced this pull request Nov 9, 2018


0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment