New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for switches in homekit controller #17916

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@drndos
Contributor

drndos commented Oct 28, 2018

Description:

This PR adds support for on/off switches on homekit_controller platform as per issue #17544

Related issue (if applicable): fixes #17544

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • N/A New dependencies have been added to the REQUIREMENTS variable (example).
  • N/A New dependencies are only imported inside functions that use them (example).
  • N/A New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • N/A New files were added to .coveragerc.

If the code does not interact with devices:

  • N/A Tests have been added to verify that the new code works.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@cadavre

This comment has been minimized.

cadavre commented Oct 31, 2018

Solution works well! I guess it's pretty straight-forward and can be merged.

@balloob balloob merged commit 9329ec2 into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on homekit-switch at 93.195%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment