New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch mailgun webhooks to the new Mailgun webhook api #17919

Merged
merged 5 commits into from Oct 30, 2018

Conversation

Projects
None yet
4 participants
@rohankapoorcom
Contributor

rohankapoorcom commented Oct 28, 2018

Description:

Home Assistant currently supports webhooks from the mailgun event api. Mailgun released a new webhook api [reference docs] which is much better (uses JSON!) and provides signed payloads for authentication.

Since we've already merged in a breaking change to dev for mailgun (migrating to the webhook component #17464 (slated for the 0.82.0 release) which requires users to make changes to their mailgun configuration to get events into Home Assistant, we could avoid a second breaking change by switching to the new api now.

Related issue (if applicable): related to #17464

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7208

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@rohankapoorcom

This comment has been minimized.

Contributor

rohankapoorcom commented Oct 28, 2018

This required a change to the strings.json. I didn't see anything in the docs that mentioned how to handle string changes when things are already translated. I ran a find/replace across all of them - let me know if there's a different way I should have handled that.

@rohankapoorcom rohankapoorcom referenced this pull request Oct 28, 2018

Merged

Update mailgun webhook settings for new api #7208

2 of 2 tasks complete
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob merged commit f0693f6 into home-assistant:dev Oct 30, 2018

4 checks passed

WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on new-mailgun-webhook-api at 93.016%
Details
@balloob

This comment has been minimized.

Member

balloob commented Oct 30, 2018

🎉

@wafflebot wafflebot bot removed the in progress label Oct 30, 2018

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:new-mailgun-webhook-api branch Oct 30, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment