New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W800rf32 #17920

Merged
merged 16 commits into from Nov 8, 2018

Conversation

Projects
None yet
6 participants
@horga83
Contributor

horga83 commented Oct 28, 2018

Description:

Adds a w800rf32 component and binary_sensor platform for use with the W800 family of X10 RF receivers.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7373

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@frenck frenck added the docs-missing label Oct 29, 2018

@MartinHjelmare

Please refactor and use our dispatch helper to communicate between component and platform entities.

Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/switch/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py Outdated

@horga83 horga83 force-pushed the horga83:w800rf32 branch from 89b241b to 7ef10b1 Nov 4, 2018

@horga83

This comment has been minimized.

Contributor

horga83 commented Nov 4, 2018

Hopefully this meets the requirements now.

@horga83 horga83 force-pushed the horga83:w800rf32 branch from 32cb091 to 43bd0f3 Nov 5, 2018

Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py
Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/w800rf32.py Outdated

@horga83 horga83 force-pushed the horga83:w800rf32 branch from ccc9584 to 5511a76 Nov 5, 2018

Show resolved Hide resolved homeassistant/components/switch/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/switch/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/binary_sensor/w800rf32.py Outdated
Show resolved Hide resolved homeassistant/components/switch/w800rf32.py Outdated

@horga83 horga83 force-pushed the horga83:w800rf32 branch from 5177443 to d50f0ba Nov 5, 2018

@klaasnicolaas klaasnicolaas referenced this pull request Nov 6, 2018

Merged

W800rf32 #7373

2 of 2 tasks complete

@horga83 horga83 force-pushed the horga83:w800rf32 branch from a3d4e67 to 0375540 Nov 6, 2018

horga83 added some commits Oct 17, 2018

Initial commit of w800rf32 component and binary_sensor.
The W800 family is an X10 RF receiver used with keypads and motion sensors etc.
Initial commit of w800rf32 switch platform.
The W800 family is an X10 RF receiver used with keypads and motion sensors etc.

@horga83 horga83 force-pushed the horga83:w800rf32 branch from d3548c2 to 6dcc867 Nov 8, 2018

@MartinHjelmare

Looks good!

Can be merged when build passes and a docs PR is linked in the PR description.

@horga83

This comment has been minimized.

Contributor

horga83 commented Nov 8, 2018

Thanks so much for your patience, I've learned a lot, a lot of stuff was copied from and older version of RFXtrx and that, in many ways didn't help, as I assumed all was correct.

I assume the "docs PR is linked in the PR description" is something you guys do?

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Nov 8, 2018

Please edit the PR description and add the link to your docs PR.

@horga83

This comment has been minimized.

Contributor

horga83 commented Nov 8, 2018

PR numbers added for here and home-assistant.io for the docs.

@MartinHjelmare MartinHjelmare merged commit 8f107c4 into home-assistant:dev Nov 8, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 93.036%
Details

@wafflebot wafflebot bot removed the in progress label Nov 8, 2018

@horga83 horga83 deleted the horga83:w800rf32 branch Nov 8, 2018

@frenck frenck removed the docs-missing label Nov 11, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

W800rf32 (home-assistant#17920)
* Initial commit of w800rf32 component and binary_sensor.

The W800 family is an X10 RF receiver used with keypads and motion sensors etc.

* Initial commit of w800rf32 switch platform.

The W800 family is an X10 RF receiver used with keypads and motion sensors etc.

* Remove unused code.

* Additions for w800rf32 component and platform code

* Fix w800rf32 minor lint issues and make sure gen_requirements.py correctlly adds w800rf32

* Added dispatch_connect/send and refactor somewhat

* Fix missed indentation lint

* Removed shared entity dict and use async_dispatch code

* Fix long line not caught by lint

* One more line too long, missed it

* Remove unused code and changes for async

* Remove  @callback that shouldn't be there.

* Remove switch platform, can't have read only switch.

* Remove unused CONF_DEBUG

* Remove used vars and make CONF_DEVICES required

* Move CONF_OFF_DELAY to platform, only used there

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment