New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry functionality failing of Unifi #17927

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
4 participants
@Kane610
Contributor

Kane610 commented Oct 28, 2018

Description:

Fix controller not being stored when setup fails and sequentially fails the retry functionality

Same fix as #17877, but fixes tests as well.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@fabaff fabaff changed the title from UniFi - Fix retry functionality failing to Fix retry functionality failing of Unifi Oct 28, 2018

@Kane610

This comment has been minimized.

Contributor

Kane610 commented Oct 29, 2018

@balloob this one would be good to get into .2

@balloob balloob added this to the 0.81.2 milestone Oct 29, 2018

@balloob balloob merged commit b03e605 into home-assistant:dev Oct 29, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on unifi-fix-retry-functionality at 93.19%
Details

@wafflebot wafflebot bot removed the in progress label Oct 29, 2018

balloob added a commit that referenced this pull request Oct 29, 2018

@balloob balloob referenced this pull request Oct 29, 2018

Merged

0.81.2 #17970

@Kane610 Kane610 deleted the Kane610:unifi-fix-retry-functionality branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment