New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract ruamel.yaml to util with secrets, lovelace ws decorators #17958

Merged
merged 10 commits into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@bramkragten
Member

bramkragten commented Oct 29, 2018

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@bramkragten bramkragten requested a review from home-assistant/core as a code owner Oct 29, 2018

@wafflebot wafflebot bot added the in progress label Oct 29, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@bramkragten bramkragten referenced this pull request Oct 29, 2018

Closed

Lovelace ws: add get and update views #17826

2 of 8 tasks complete

@bramkragten bramkragten changed the title from Extract ruamel.yaml to util, ws decorators, secrets to Extract ruamel.yaml to util with secrets, lovelace ws decorators Oct 29, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@@ -46,6 +46,7 @@
'pytz>=2018.04',
'pyyaml>=3.13,<4',
'requests==2.19.1',
'ruamel.yaml==0.15.72',

This comment has been minimized.

@balloob

balloob Oct 29, 2018

Member

FYI this is one of the very rare occasions that we add a core dependency. And it's only because ruamel will eventually replace pyyaml.

@balloob

Ok to merge pending response how to deal with extending SafeConstructor

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

bramkragten added some commits Oct 29, 2018

@bramkragten bramkragten force-pushed the bramkragten:lovelace-secrets branch from b15e0ee to 423b0a7 Oct 31, 2018

Extend SafeConstructor
Somehow my last commit is gone after rebase...

bramkragten added some commits Oct 31, 2018

@bramkragten bramkragten requested a review from kellerza as a code owner Oct 31, 2018

bramkragten added some commits Oct 31, 2018

@balloob balloob merged commit b763c0f into home-assistant:dev Oct 31, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 93.092%
Details

@wafflebot wafflebot bot removed the in progress label Oct 31, 2018

@bramkragten bramkragten deleted the bramkragten:lovelace-secrets branch Oct 31, 2018

@bramkragten bramkragten referenced this pull request Nov 6, 2018

Merged

Update lovelace ID status + include and secret support #7395

2 of 2 tasks complete

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment