New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mill service #17971

Merged
merged 2 commits into from Oct 29, 2018

Conversation

Projects
None yet
4 participants
@Danielhiversen
Member

Danielhiversen commented Oct 29, 2018

Description:

Add a service to control the room temperature for the Mill heater

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7235

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Danielhiversen added some commits Oct 29, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@Danielhiversen Danielhiversen referenced this pull request Oct 29, 2018

Merged

Update climate.mill.markdown #7235

1 of 2 tasks complete
@fabaff

fabaff approved these changes Oct 29, 2018

Looks good to me 🐦

@fabaff fabaff merged commit 9816350 into dev Oct 29, 2018

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on mill_service at 93.007%
Details

@wafflebot wafflebot bot removed the in progress label Oct 29, 2018

@fabaff fabaff deleted the mill_service branch Oct 29, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment