New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operation mode for Alexa thermostat #17972

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@balloob
Member

balloob commented Oct 29, 2018

Description:

On Py3.5, dictionaries are not ordered. Making it explicitely an ordered dict because we do a reverse lookup when mapping Alexa -> HA and we want to have the first match for OFF.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob merged commit d6913c6 into dev Oct 29, 2018

3 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Oct 29, 2018

@balloob balloob deleted the alexa-thermostat-modes branch Oct 29, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment