New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use keyset #17984

Merged
merged 1 commit into from Oct 29, 2018

Conversation

@balloob
Member

balloob commented Oct 29, 2018

Description:

Removes fetching the keyset. It's only used to verify that we read sub-exp correctly, which is being verified in the cloud anyway.

Related issue (if applicable): fixes #14089, fixes #15221

Example entry for configuration.yaml (if applicable):

cloud:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.81.2 milestone Oct 29, 2018

@balloob balloob requested a review from home-assistant/core as a code owner Oct 29, 2018

@wafflebot wafflebot bot added the in progress label Oct 29, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob force-pushed the remove-keyset branch from b93552f to 61b4ea9 Oct 29, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob merged commit 2f71f89 into dev Oct 29, 2018

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Oct 29, 2018

balloob added a commit that referenced this pull request Oct 29, 2018

@balloob balloob referenced this pull request Oct 29, 2018

Merged

0.81.2 #17970

@pvizeli pvizeli deleted the remove-keyset branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment