New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import homeassistant domain instead of hardcoding it #17985

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
4 participants
@scop
Contributor

scop commented Oct 29, 2018

Description:

SSIA.

Checklist:

  • The code change is tested and works locally.
  • [x ] Local tests pass with tox. Your PR cannot be merged unless tests pass

@scop scop requested a review from home-assistant/core as a code owner Oct 29, 2018

@wafflebot wafflebot bot assigned scop Oct 29, 2018

@wafflebot wafflebot bot added the in progress label Oct 29, 2018

@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@scop scop merged commit 4d9ef9e into home-assistant:dev Oct 30, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on hass-domain-import at 93.007%
Details

@wafflebot wafflebot bot removed the in progress label Oct 30, 2018

@scop scop deleted the scop:hass-domain-import branch Oct 30, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment