New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes of ARP table #17987

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@akloeckner
Contributor

akloeckner commented Oct 29, 2018

This adds the device attributes available in the ARP table and a few more. Implementation is inspired by the nmap scanner.

Description:

Related issue (if applicable): none
Related feature request: https://community.home-assistant.io/t/luci-device-scanner-with-ip-address/71447

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7251

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: luci
    host: !secret luci_shak_ip
    username: !secret luci_shak_username
    password: !secret luci_shak_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Add attributes of ARP table
This adds the device attributes available in the ARP table and a few more. Implementation is inspired by the nmap scanner.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@akloeckner akloeckner referenced this pull request Oct 29, 2018

Merged

Additional attributes and hint to manual bug fix #7251

2 of 2 tasks complete
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'
@balloob

balloob approved these changes Nov 6, 2018

@balloob balloob merged commit 1aba469 into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on luci_with_att at 93.007%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Add attributes of ARP table (home-assistant#17987)
* Add attributes of ARP table

This adds the device attributes available in the ARP table and a few more. Implementation is inspired by the nmap scanner.

* lint spaces

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment