New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SMA sensor #17988

Merged
merged 3 commits into from Oct 31, 2018

Conversation

Projects
None yet
6 participants
@kellerza
Member

kellerza commented Oct 29, 2018

Description:

Updated pysma to 0.2.2 and uses the new attr based sensors

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sensor:
  pysma:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@houndci-bot

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

kellerza added some commits Oct 28, 2018

sma

@kellerza kellerza force-pushed the kellerza:smajmes branch from e4bedc5 to d578944 Oct 31, 2018

@kellerza kellerza changed the title from [WIP] Update SMA sensor to Update SMA sensor Oct 31, 2018

@kellerza kellerza merged commit 7363378 into home-assistant:dev Oct 31, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 93.093%
Details

@wafflebot wafflebot bot removed the in progress label Oct 31, 2018

@kellerza kellerza deleted the kellerza:smajmes branch Oct 31, 2018



def _check_sensor_schema(conf):
"""Check sensors and attributes are valid."""
import pysma

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Oct 31, 2018

Member

Requirements are not available when config validation is taking place.

This comment has been minimized.

@kellerza

kellerza Oct 31, 2018

Member

Thx, I asked in the chat, but had no reply there. Will update & move this to the setup routine

@kellerza kellerza referenced this pull request Nov 1, 2018

Merged

SMA: Optional import in schema & backoff fix #18099

2 of 2 tasks complete
@grantclem

This comment has been minimized.

grantclem commented Nov 4, 2018

There appears to be an issue with the SMA component (has been working fine up until now) you can check out the beta channel on Discord for more information. Basically when it is enabled a lot of my sensors are missing. If I disable the component (SMA), all sensors return. Logs are not telling me much sorry.

@kellerza

This comment has been minimized.

Member

kellerza commented Nov 4, 2018

It should be fixed in #18099

@JoooostB

This comment has been minimized.

JoooostB commented Nov 5, 2018

It should be fixed in #18099

Updated to the dev container a couple of minutes ago, but still experiencing the same issue as @grantclem

@grantclem

This comment has been minimized.

grantclem commented Nov 5, 2018

still no change with 0.82b2

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment