New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add niko-home-control support #18019

Merged
merged 4 commits into from Nov 12, 2018

Conversation

@legovaer
Contributor

legovaer commented Oct 30, 2018

Description:

This is a follow-up PR for #13755

Add support for niko-home-control

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5137

Example entry for configuration.yaml (if applicable):

light:
  - platform: niko_home_control
    host: 192.168.1.123

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@homeassistant

This comment was marked as resolved.

homeassistant commented Oct 30, 2018

Hello @legovaer,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@legovaer legovaer force-pushed the legovaer:feature/niko-home-control branch from b2b2ee0 to 9eb0b80 Oct 30, 2018

@homeassistant

This comment has been minimized.

homeassistant commented Oct 30, 2018

Hi @legovaer,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@legovaer legovaer force-pushed the legovaer:feature/niko-home-control branch from 9eb0b80 to e90870e Oct 30, 2018

@fabaff fabaff referenced this pull request Nov 12, 2018

Merged

Add niko-home-control documentation #5137

2 of 2 tasks complete
@fabaff

fabaff approved these changes Nov 12, 2018

Thanks 🐦

Please update the documentation as the current state is from April

@fabaff fabaff merged commit 15c77fe into home-assistant:dev Nov 12, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 93.038%
Details

@wafflebot wafflebot bot removed the in progress label Nov 12, 2018

'timeout': 20000,
'events': True
})
except socket.error as err:

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 12, 2018

Member

Socket error is deprecated in favor of OSError in modern versions of Python 3.

})
def setup_platform(hass, config, add_devices, discovery_info=None):

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 12, 2018

Member

We have renamed add_devices to add_entities.

"""Set up the Niko Home Control light platform."""
import nikohomecontrol
host = config.get(CONF_HOST)

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 12, 2018

Member

Use dict[key] for required config keys.

"""Instruct the light to turn on."""
self._light.brightness = kwargs.get(ATTR_BRIGHTNESS, 255)
self._light.turn_on()
self._state = True

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 12, 2018

Member

This will be updated by self.update in the end of the service call.

@property
def brightness(self):
"""Return the brightness of the light."""
return self._brightness

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 12, 2018

Member

Where is this updated?

def turn_off(self, **kwargs):
"""Instruct the light to turn off."""
self._light.turn_off()
self._state = False

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 12, 2018

Member

See above.

@fabaff fabaff referenced this pull request Nov 12, 2018

Merged

Fix niko home control remaining issues #18416

2 of 3 tasks complete

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Add niko-home-control support (home-assistant#18019)
* Add niko-home-control support

* Remove the sensor platform

* Minor changes

* Fix docstring

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment