New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ssdp udn uuid as Samsung TV unique id #18022

Merged
merged 3 commits into from Nov 2, 2018

Conversation

Projects
None yet
4 participants
@scop
Contributor

scop commented Oct 30, 2018

Description:

Similarly as 5d96751 for Panasonic Viera TV's.

Related issue (if applicable): #13541

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
@kellerza

Wanted to ask why not use the mac, then it should apply to both?

But looking into this, mac is not passed during discovery and with static config, mac is not part of the PLATFORM_SCHEMA.

Any idea why you have mac and wakeonlan?

@scop

This comment has been minimized.

Contributor

scop commented Nov 1, 2018

Mac and wakeonlan appear to be there so one can wake up the TV if it's so powered off that the KEY_POWERON way doesn't work. Just guessing, haven't tested, but anyway kind of unrelated to this PR I think :)

@@ -84,7 +88,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
class SamsungTVDevice(MediaPlayerDevice):
"""Representation of a Samsung TV."""

def __init__(self, host, port, name, timeout, mac):
def __init__(self, host, port, name, timeout, mac, uuid=None):

This comment has been minimized.

@pvizeli

pvizeli Nov 1, 2018

Member

def __init__(self, host, port, name, timeout, mac, uuid): I see no reason make it optional.

@pvizeli

pvizeli approved these changes Nov 1, 2018

@kellerza

This comment has been minimized.

Member

kellerza commented Nov 1, 2018

According to Travis you need to fix some tests

@kellerza kellerza merged commit a4c0c34 into home-assistant:dev Nov 2, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 93.059%
Details

@wafflebot wafflebot bot removed the in progress label Nov 2, 2018

@scop scop deleted the scop:samsung-tv-uuid branch Nov 2, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment